Add back accidentally removed contributors

[ccuser44]

Add back accidentally removed contributors from 6dea67a

I couldn't find any information about NoUserSet who changed from ExternalScript and before that was apparently known as Obelusis.
Also unrelated to this it's unknown if the user 24rr is in the credits but under a different name.

No PoF needed for obvious reasons.

[GalacticInspired]

This was no accident, removed handles either have no contribution history or they are no longer validly pointing to a user.

[ccuser44]

This was no accident, removed handles either have no contribution history

The only one I couldn't find contribution history of is Obelusis.

or they are no longer validly point to a user.

That's not a valid reason to remove someone from the credits.
Just because someone doesn't have a Github account doesn't mean their name should be removed from the list.
Most of the handles still point to a valid account. Most users on the list (apart from 2 accounts and Obelusis) that were removed from the list actually have a valid account and were just renamed

[GalacticInspired]

This was no accident, removed handles either have no contribution history

The only one I couldn't find contribution history of is Obelusis.

or they are no longer validly point to a user.

That's not a valid reason to remove someone from the credits. Just because someone doesn't have a Github account doesn't mean you should remove their name. In fact that's stealing credit and is illegal. And it's not actually true that the handles don't piint to a valid account. Most users on the list (apart from 2 accounts and Obelusis) that were removed from the list actually have a valid account and were just renamed

I don't think you've properly reviewed each and every handle like I have. All handles that had a name change were updated, and handles that lead to a 404 page where no activity can be found were removed. You are correct that some removed handles still point to a user account, but have you actually reviewed their contributions?

gjkeller: No visible relations to Adonis
AaronVickers: No visible relations to Adonis
ken-tn: No visible relations to Adonis
enescglyn: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.
Kw6m: This account was deleted.
L8X: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.

If we were to keep the @ handles that other people have acquired, then they are "claiming" credit for something they have not worked on.

[ccuser44]

gjkeller: No visible relations to Adonis
AaronVickers: No visible relations to Adonis
ken-tn: No visible relations to Adonis
enescglyn: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.
Kw6m: This account was deleted.
L8X: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.

If we were to keep the @ handles that other people have acquired, then they are "claiming" credit for something they have not worked on.

I think you may be right about some of the usernames but ken-tn was an early Adonis (quasi) maintainer, AaronVickers (GeneralScripter) certainly had pull requests (from what I remember). Likewise the deleted accounts Kw6m and L8X both had actual code contributions. I think we can maybe remove the @ from the deleted accounts but I think it would still be appropriate to keep them.

[GalacticInspired]

gjkeller: No visible relations to Adonis

AaronVickers: No visible relations to Adonis

ken-tn: No visible relations to Adonis

enescglyn: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.

Kw6m: This account was deleted.

L8X: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.

If we were to keep the @ handles that other people have acquired, then they are "claiming" credit for something they have not worked on.

I think you may be right about some of the usernames but ken-tn was an early Adonis (quasi) maintainer, AaronVickers (GeneralScripter) certainly had pull requests (from what I remember). Likewise the deleted accounts Kw6m and L8X both had actual code contributions. I think we can maybe remove the @ from the deleted accounts but I think it would still be appropriate to keep them.

I am open to ideas to combat it, just not this implementation.

[ccuser44]

gjkeller: No visible relations to Adonis

AaronVickers: No visible relations to Adonis

ken-tn: No visible relations to Adonis

enescglyn: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.

Kw6m: This account was deleted.

L8X: This account was deleted, and the handle was acquired by a new person, meaning this is not the same person as before.

If we were to keep the @ handles that other people have acquired, then they are "claiming" credit for something they have not worked on.

I think you may be right about some of the usernames but ken-tn was an early Adonis (quasi) maintainer, AaronVickers (GeneralScripter) certainly had pull requests (from what I remember). Likewise the deleted accounts Kw6m and L8X both had actual code contributions. I think we can maybe remove the @ from the deleted accounts but I think it would still be appropriate to keep them.

I am open to ideas to combat it, just not this implementation.

Okay I've removed the accounts without substantial contributions and removed the @ handles from the deleted accounts. Let me know if other possible changes need to be made.

[ccuser44]

Actually on second thought gjkeller's contribution might be notable enough to warrant credit because they added notifypm and countdown PM. https://github.com/Epix-Incorporated/Adonis/pull/106/changes

[GalacticInspired]

Actually on second thought gjkeller's contribution might be notable enough to warrant credit because they added notifypm and countdown PM. https://github.com/Epix-Incorporated/Adonis/pull/106/changes

Woah, not sure how you found this, but feel free to keep them in with the @!

[ccuser44]

On a second note it might be better to removed the deleted accounts because one of them (I'm not going to name which one) is not a good person and probably shouldn't be in the credits page. As well as the fact that someone else holds the handles.