Support serializing FlagConfigResponse #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation didn't have a serializer `EppoValueSerializer` should only write one value: Previous implemenation could write multiple values (would always write a `null`) for anything that isn't an `ARRAY_OF_STRING` type
hbordersTwitch
force-pushed
the
hbordersTwitch/add_serialization
branch
from
202e4f0 to
3d2f334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation didn't have a serializer
EppoValueSerializershould only write one value: Previous implemenation could write multiple values (would always write anull) for anything that isn't anARRAY_OF_STRINGtypeEppo Internal:
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
We want to preserve old flag values on our clients, so we need to be able to serialize a
FlagConfigResponsethat we generate on the client by combining the newly receivedFlagConfigResposneand the existingFlagConfigResponseDescription
Wrote a
FlagConfigResponseSerializerthat mirrors the implementation inFlagConfigResponseDeserializerHow has this been documented?
Added equivalent javadoc to what existed in
FlagConfigResponseDeserializerHow has this been tested?
Added equivalent testing to what existed in
FlagConfigResponseSerializer. Added another case to test serializing / deserializingBanditReference