[BROKEN UP] Assignment Details #173
Conversation
aarsilv
force-pushed
the
aarsilv/ffesupport-378/assignment-details
branch
from
f78aab6 to
790d5cf
Compare
| * user-facing AssignmentDetails result class. If any error in the evaluation, the result value | ||
| * will be set to the default value. | ||
| */ | ||
| protected <T> AssignmentDetails<T> getTypedAssignmentWithDetails( |
There was a problem hiding this comment.
Use of generic so that customer's code don't have to unwrap an EppoValue if they retrieve the variation (which is top level, typed T). Unwrapping happens as last step in this method.
|
|
||
| public boolean getBooleanAssignment( | ||
| String flagKey, String subjectKey, Attributes subjectAttributes, boolean defaultValue) { | ||
| return this.getBooleanAssignmentDetails(flagKey, subjectKey, subjectAttributes, defaultValue) |
There was a problem hiding this comment.
For our non-details methods we get the details and just pull the variation. This increases CPU time by about 50% as measured in ProfileBaseEppoClientTest. However I think that penalty is worth the simplicity as this is still fast and we're moving to Datadog SDKs. We can look into optimizing more later if needed.
| new Date(1713382853716L); // 2024-04-17T19:40:53.716Z; matches flags-v1.json | ||
| assertEquals(expectedPublishedAt, details.getConfigPublishedAt()); | ||
| // Fetched at should be after published at (it's set when config is built) | ||
| assertTrue( |
There was a problem hiding this comment.
Our shared test cases don't check these dates are correctly populated so I threw it into this test case just so its checked somewhere.
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I don't know why only the JSON methods had Javadocs, but claude decided to be consistent and remove them and I agree.
If we want all public methods to have docs we can add them back in a later PR.
aarsilv
changed the base branch from
main
to
aarsilv/ffesupport-378/part3-ingest-test-case-details
aarsilv
changed the base branch from
aarsilv/ffesupport-378/part3-ingest-test-case-details
to
main
Do not review; this has been broken up into multiple PRs