Resolve exclude correctly #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I resolved an issue where, in an already constructed environment, repositories were cloned before being excluded due to the order in which they were discovered.
From now on, only the directories listed in the initially specified .repos file will be recursively searched.
In other words, even if there are other .repos files or manually cloned repositories in the workspace, those .repos files will no longer be part of the search targets.
I believe this behavior is correct for an “import based on the initially specified .repos file.”
Separately, there may be value in having a feature that imports all .repos files discovered across the entire workspace, without an initially specified .repos file.
However, I consider that to be a different issue.
Additionally, during testing, I noticed that attempting to change only the version of an already cloned repository resulted in “Skipped cloning,” and the version remained unchanged.
To address this, I made it so that even if the repository is already cloned, it will be switched if the version differs. f241ad4
test behavior
nested_example2.repos
go run main.go import -i ./test/nested_example2.repos /tmp/example --recursive -x naoqi_libqicore