CI for unit tests#28
Conversation
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Whats the gain of blanket copy-pasting the entire Analysis job including printing the versions? I'm fine not creating a new job, and simply adding the test runs on the end.
While we are still hashing out the test directory structure in #22, I suppose I'm more in favour of finally running these tests on every PR before we rework everything. But, this is also no hill I intend to die on.
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
I like that the patch is leaner.
|
Please review #37 |
|
@nettle, I commented with my recommendations on where to make adjustments to the documentation. It seems to me that nothing that What do you think? |
nettle
dismissed
their stale review
Please do not treat this as "Request to change"
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Please remove the README.md change. Otherwise LGTM
|
I removed the line and also rebased from main |
This reverts commit f89f300.
We should run the unit tests for every commit! I have added the update-alternative command, because by default, `clang-extdef-mapping` was only accessible through `clang-extdef-mapping-18` removed `--stat` option, opensource clang doesn't support this flag While all tests are passing, keep Ericsson#26 in mind! It only passes because we don't install cppcheck or Infer.
4 participants
We should run the unit tests for every commit!
I have added the update-alternative command, because by default,
clang-extdef-mappingwas only accessible throughclang-extdef-mapping-18removed
--statoption, opensource clang doesn't support this flagWhile all tests are passing, keep #26 in mind! It only passes because we don't install cppcheck or Infer.