Skip to content

Round 2 of fixes #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mirabilos wants to merge 12 commits into from
Closed

Round 2 of fixes #34

mirabilos wants to merge 12 commits into from

Conversation

@mirabilos
Copy link
Contributor

@mirabilos mirabilos commented Jun 30, 2020

Hi @IngJohEricsson,

this is round 2 of my fixes. I verified I can reach 200+ kbps with this (now that I know it’s bit, not bytes), and I did not symlink the files again.

  • fix the file types issue, so this can actually be checked out on Unix/Linux
  • clean up whitespace, const, comments, UINT32_MAX, etc. again
  • fix unreachable statement (matches the other two RtpQueue.cpp files in the repository)
  • add the build instructions to README.md which I already prepared

mirabilos added 4 commits June 30, 2020 13:37
@mirabilos
repair file types (symbolic link vs. regular file)
46a6d8d
@mirabilos
apply the changes I know are absolutely correct
9b623e4 
• whitespace cleanup / harmonisation
• const
• some ordering without side effects
• comments
• correct type *_MAX constant
@mirabilos
add build instructions for everything found in this repository
37ee23a 
(cherry picked from commit 34ecd11)
@mirabilos
apply another bugfix from the two other RtpQueue impl files
71a43ad 
still works:
 58.1  Transmit rate = 202059kbps, PLR =  0.00%( 0.00%), RTT = 0.000s, Queue delay = 0.000s
@mirabilos
Copy link
Contributor Author

mirabilos commented Jul 3, 2020

@IngJohEricsson I’ve rebased my changes you already approved on today’s latest master branch, converted symlinks to includes (as it’s clear symlinks won’t work) and fixed gscream to at least compile. Please merge ;-)

@mirabilos
Copy link
Contributor Author

mirabilos commented Jun 27, 2022

superceded by #46

@mirabilos mirabilos closed this Jun 27, 2022
@mirabilos mirabilos deleted the round2 branch June 27, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IngJohEricsson IngJohEricsson IngJohEricsson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mirabilos @IngJohEricsson