Skip to content

Fix num reports field #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mengelbart wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix num reports field #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/ScreamRx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,9 @@ bool ScreamRx::Stream::getStandardizedFeedback(uint32_t time_ntp,
size += 2;

/*
* Write number of reports- 1
* Write number of reports
*/
tmp_s = nReportedRtpPackets - 1;
tmp_s = nReportedRtpPackets;
tmp_s = htons(tmp_s);
memcpy(buf + 6, &tmp_s, 2);
size += 2;
Expand Down
2 changes: 1 addition & 1 deletion code/ScreamV2Tx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ void ScreamV2Tx::incomingStandardizedFeedback(uint32_t time_ntp,
memcpy(&num_reports, buf + ptr, 2);
ptr += 2;
begin_seq = ntohs(begin_seq);
num_reports = ntohs(num_reports) + 1;
num_reports = ntohs(num_reports);
end_seq = begin_seq + num_reports - 1;

/*
Expand Down
4 changes: 2 additions & 2 deletions gstscream/src/screamrx/ScreamRx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,9 @@ impl Stream {
};
bytes.extend_from_slice(&tmp_s.to_be_bytes());
/*
* Write number of reports- 1
* Write number of reports
*/
let tmp_s: u16 = (self.nReportedRtpPackets - 1).try_into().unwrap();
let tmp_s: u16 = (self.nReportedRtpPackets).try_into().unwrap();
bytes.extend_from_slice(&tmp_s.to_be_bytes());

/*
Expand Down