Skip to content

Snap geometry edits fix #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v.next
Choose a base branch
from
Open

Snap geometry edits fix #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e63ec0
Add in a load dialog to populate snap settings
shubham7109 Oct 28, 2025
6b51679
cleanup import
shubham7109 Oct 28, 2025
0210dec
PR feedback
shubham7109 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ava/com/esri/arcgismaps/sample/snapgeometryedits/components/SnapGeometryEditsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ class SnapGeometryEditsViewModel(
val snapSourceList: StateFlow<List<SnapSourceSettings>> = _snapSourceSettingsList

// create boolean flags to track the state of UI components
val areLayersLoading = mutableStateOf(true)
val isCreateButtonEnabled = mutableStateOf(false)
val isSnapSettingsButtonEnabled = mutableStateOf(false)
val isBottomSheetVisible = mutableStateOf(false)
Expand Down Expand Up @@ -104,7 +105,9 @@ class SnapGeometryEditsViewModel(
)
}
}
areLayersLoading.value = false
}.onFailure { error ->
areLayersLoading.value = false
messageDialogVM.showMessageDialog(
error.message.toString(),
error.cause.toString()
Expand Down
4 changes: 4 additions & 0 deletions ...main/java/com/esri/arcgismaps/sample/snapgeometryedits/screens/SnapGeometryEditsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalContext
import com.arcgismaps.toolkit.geoviewcompose.MapView
import com.esri.arcgismaps.sample.sampleslib.components.LoadingDialog
import com.esri.arcgismaps.sample.sampleslib.components.MessageDialog
import com.esri.arcgismaps.sample.sampleslib.components.SampleTopAppBar
import com.esri.arcgismaps.sample.snapgeometryedits.components.SnapGeometryEditsViewModel
Expand Down Expand Up @@ -102,5 +103,8 @@ fun MainScreen(sampleName: String) {
) { mapViewModel.dismissBottomSheet() }
}
}
if (mapViewModel.areLayersLoading.value) {
LoadingDialog("Loading map with feature layers...")
}
})
}
Loading