Skip to content

servo: remove unused scaffolding and docs#1

Open
eureka-igal wants to merge 24 commits intodevelopfrom
feature/servo-competition-provider
Open

servo: remove unused scaffolding and docs#1
eureka-igal wants to merge 24 commits intodevelopfrom
feature/servo-competition-provider

Conversation

@eureka-igal
Copy link
Collaborator

Summary

  • Remove unused SERVO scaffolding and migration doc.

Changes

  • Delete docs/servo-migration-plan.md (internal migration notes)
  • Delete crates/rbuilder/src/eureka/servo/bidder.rs (unused ServoBiddingService)
  • Drop bidder/enriching_service exports from crates/rbuilder/src/eureka/servo/mod.rs
  • Kept all rbuilder-*.toml files intact as requested

Verification

  • cargo check: clean (no errors)

Rationale

  • Code and docs are unused in the current architecture (SERVO runs via plugin WS ingest + HTTP bidder; competition feed via NNG). Removing them reduces maintenance and confusion.

ZanCorDX and others added 24 commits September 15, 2025 11:50
… new crate for plugin implementations (noop registrars); update workspace members

Amp-Thread-ID: https://ampcode.com/threads/T-a536b43d-a0d3-4888-8501-896ee230941f
Co-authored-by: Amp <amp@ampcode.com>
…rder-input start) behind `plugins` feature (#1)
…ugin/eureka wiring (#2)

* feat(toba): add is_toba metadata flag and accessors; rework RpcHook to register with deps; plumb hooks into RPC server

Amp-Thread-ID: https://ampcode.com/threads/T-a536b43d-a0d3-4888-8501-896ee230941f
Co-authored-by: Amp <amp@ampcode.com>

* feat(toba): register eth_sendRawTransactionToba via extra_rpc using eureka crate; add is_toba metadata; avoid config flags; optional 'eureka' feature

Amp-Thread-ID: https://ampcode.com/threads/T-a536b43d-a0d3-4888-8501-896ee230941f
Co-authored-by: Amp <amp@ampcode.com>

* chore: remove 'plugins' and 'eureka' feature flags; always compile plugin API and eureka TOBA RPC; make eureka a non-optional dep; ungate hook plumbing

Amp-Thread-ID: https://ampcode.com/threads/T-a536b43d-a0d3-4888-8501-896ee230941f
Co-authored-by: Amp <amp@ampcode.com>

* refactor(toba): register eth_sendRawTransactionToba via RpcHook; add eureka hook registration in builder; remove direct extra_rpc call

Amp-Thread-ID: https://ampcode.com/threads/T-a536b43d-a0d3-4888-8501-896ee230941f
Co-authored-by: Amp <amp@ampcode.com>

---------

Co-authored-by: Amp <amp@ampcode.com>
…on new BlockBidWithStatsObs sink wiring

Amp-Thread-ID: https://ampcode.com/threads/T-fab665b1-3eb8-4c2d-afff-44fa5cf7d0db
Co-authored-by: Amp <amp@ampcode.com>
…lugins; inline slot context; wire WS→orderpool and HTTP bidder.

- Plugins config: [servo] all-or-nothing, no ; required ws/http/el/bearer/secret
- ServoWsFetcher: consume required cfg, subscribe to inline slot context, start HTTP bidder
- Inline slot context publisher/subscriber in live_builder::mod (remove separate module)
- Remove ServoNngBidFeedPlugin and manual servo_slot_context
- Add Servo HTTP client, stake & ERC20 wrappers; HTTP bidder consumes broadcast context
- Builder: enable SERVO multiplexing when [servo] exists in TOML (no env)
- fmt + clippy clean

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
…ve mux usage; set global SERVO coordinator when [servo] present and feed it from NNG.

- TBV is always the bidding service
- If [servo] exists, create/set global ServoBidCoordinator
- Wrap NNG scraped bids observer to also update coordinator
- No env flags, no mux; SERVO HTTP bidder runs independently via plugin

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
…bidder. SERVO is optional via [servo] and runs HTTP bidder independently.

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
…b chain_id from /info; keep TBV-only in-process bidding.

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
…eshooting (slot ctx state, competition snapshots, eval decisions, cache updates).

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
…ersion="1"); use alloy_signer LocalSigner::sign_hash_sync; remove manual fixed arrays; align field order.

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
…lloy-signer, per-slot base tracking, safety checks, and richer logs; coordinator log improvements.

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
- Delete docs/servo-migration-plan.md (migration doc)
- Delete eureka/servo/bidder.rs (unused ServoBiddingService)
- Remove bidder/enriching_service exports from eureka/servo/mod.rs
- Keep all rbuilder-*.toml files intact as requested
- Run rustfmt across workspace

Amp-Thread-ID: https://ampcode.com/threads/T-caccf6dc-17c3-476a-83ff-237ac2a7cc8a
Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants