Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
If this fits in with using |
takluyver
reviewed
Jan 23, 2026
philsmt
force-pushed
the
feat/keydata-train-index
branch
from
8857c23 to
b9daf72
Compare
Contributor
Author
|
Sure, I switched the default to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using data with more than one entry per train, I find it sometimes convenient (and also regularly more performant) to use plain old ndarrays and have arrays lying around indicating the first and last index of a given train.
This PR adds a method
KeyData.train_index_bounds()to deliver this based onKeyData.data_counts(). I went with the traditionallabelledapproach, though I don't have hard feelings for that.