Conversation
e72759e to
6754d9c
Compare
|
Reminder to myself: Add pulse height information to edges, if available. |
6754d9c to
d33dd40
Compare
|
@JamesWrigley Could I ask you as well to have a brief look? It's been dangling for a bit now, and I would like to base more components off it. |
JamesWrigley
left a comment
There was a problem hiding this comment.
I should say that I'm completely unfamiliar with DLD's, so I may have missed something 👀
|
I found the I think my question about RUN values is worth thinking about before we merge this. |
|
Do you feel strongly about the complexity of |
|
No, I don't feel strongly about it. 🙂 |
a534bb0 to
0a0d6b7
Compare
|
@takluyver I ended up giving it another try to reduce the complexity of |
takluyver
left a comment
There was a problem hiding this comment.
Thanks, that does look easier to read now.
4216c16 to
3b7b0e7
Compare
|
Thanks for review! |
For various delay line detectors in use at SQS, the offline calibration pipeline is used to digitize the analog signals recorded with digitizers and reconstruct them into proper detector hits in time and space as a virtual detector source. As this kind of data is variable-length by nature, it is saved in sufficiently large fixed-length arrays filled with
np.nanand compressed away.While this data format is very efficient for storage and interoperable, it is somewhat difficult to load and work on in a pulse or hit-based manner. Based on observations of existing user code, this component transform the train/pulse/hit-shaped data into a linear
pd.Seriesorpd.DataFramewith multi indices for convenient access.It integrates into the existing pulse pattern components, though by default will use the internal pulse information saved as part of the processing result.