Conversation
added 3 commits
January 26, 2026 14:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 72.87% 72.92% +0.05%
==========================================
Files 35 35
Lines 6093 6105 +12
==========================================
+ Hits 4440 4452 +12
Misses 1653 1653 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philsmt
reviewed
Jan 27, 2026
philsmt
reviewed
Jan 28, 2026
philsmt
reviewed
Jan 29, 2026
Contributor
Author
|
I updated the PR description after the changes discussed. If there are no other comments, I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR factors out the cross section and includes the XFEL polarization in the CookieboxCalibration, so that the polarization of the beam can be included in the transmission calculation.
The only API change is the inclusion of the
beta,P1andtiltparameters in the constructor, which allows one to set the photo-electron angular dependence parametrization. The default setup corresponds to a standard configuration of horizontal polarization. They are also serialised to HDF5.