feat: add dom.iterable lib in TS compiler options#69
Merged
Conversation
vouill
approved these changes
Apr 2, 2025
Member
Author
|
@vouill Est-ce qu'on considère ça comme suffisamment impactant pour être une nouvelle version majeure au fait ? |
Contributor
Oui je pense pareil, donc pas besoin de version majeure imo 97% should be good |
190c55e to
c24ea03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposition : ajout de la lib "dom.iterable" dans la config TypeScript
Pourquoi ?
J'avais écrit ça dans une PR :
Parce que la règle ESLint m'empêchait d'écrire :
Mais du coup ça pètait une erreur TypeScript au build time :