Combined ComplexUnaligned with Complex to use a Sentinel Value for Alignment #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also combine IsAligned with IsSequenceable. We do this to reduce the number of classes we need to consider, there was some annoyance with regards to complex MROs with this many classes and interfaces interlocking each other. The easier design we pitch here is to have alignment be decided by a nully sentinel value of NoAlignment instead of having a separate class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
We found difficulty in doing some resolution (MRO) in our design with these many interlocking classes, thus it's best that if we can thin down the number of classes. The intermediatery format of ComplexUnaligned wasn't great and felt like code-smell, thus we're changing it up for a simpler less heavy design by using a sentinel value to determine alignmentness.
As a result, since we don't have anymore separation of Unaligned/Aligned class, we also drop IsSequenceable and move it towards IsAligned, we might change the name later