fix: remove redundant base64 handler #2146
Open
+682
−632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anteriormente, o endpoint findContacts processava apenas o campo remoteJid da cláusula where, ignorando outros campos como id e pushName. Alterações: - Atualiza método fetchContacts para processar todos os campos do where (id, remoteJid, pushName) - Adiciona campo remoteJid ao contactValidateSchema para validação adequada - Garante isolamento multi-tenant mantendo filtro por instanceId Esta correção permite que usuários filtrem contatos por qualquer um dos campos suportados ao invés de sempre retornar todos os contatos da instância.
fix(chat): apply where filters correctly in findContacts endpoint
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors base64 handling in ChannelStartupService by dropping redundant mediaUrl backup/restore and simplifying the deletion of the base64 field within the message existence check. Class diagram for updated ChannelStartupService message cleaningclassDiagram
class ChannelStartupService {
+cleanedMessage: object
+cleanMessage(message: object): object
}
class Message {
base64: string
mediaUrl: string
imageMessage: object
}
ChannelStartupService --|> Message
%% Changes:
%% - Removed redundant mediaUrl backup/restore logic
%% - Simplified base64 field deletion within message existence check
%% - No longer restores mediaUrl after cleaning
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- There’s a duplicate delete of cleanedMessage.message.base64; remove the redundant invocation to avoid confusion.
- You’ve removed the mediaUrl preservation logic—double-check that this won’t inadvertently strip mediaUrl from your API response.
- Consider flattening the base64 cleanup block instead of nested ifs to improve readability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a duplicate delete of cleanedMessage.message.base64; remove the redundant invocation to avoid confusion.
- You’ve removed the mediaUrl preservation logic—double-check that this won’t inadvertently strip mediaUrl from your API response.
- Consider flattening the base64 cleanup block instead of nested ifs to improve readability.
## Individual Comments
### Comment 1
<location> `src/api/services/channel.service.ts:539-540` </location>
<code_context>
- delete cleanedMessage.message.base64;
-
if (cleanedMessage.message) {
+ if (cleanedMessage.message.base64) {
+ delete cleanedMessage.message.base64;
+ }
+
</code_context>
<issue_to_address>
**suggestion:** Redundant deletion of 'base64' property from cleanedMessage.message.
Only one deletion is needed; please remove the redundant statement.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+539
to
+540
| if (cleanedMessage.message.base64) { | ||
| delete cleanedMessage.message.base64; |
There was a problem hiding this comment.
suggestion: Redundant deletion of 'base64' property from cleanedMessage.message.
Only one deletion is needed; please remove the redundant statement.
|
why are u changing the source of the image docker to your personal image, instead of evoapicloud/evolution-api image? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
This part of the code returns
{
"status": 500,
"error": "Internal Server Error",
"response": {
"message": "Cannot read properties of null (reading 'mediaUrl')"
}
}
in /findChats/ API endpoint, e.g:
http://localhost:8080/chat/findChats/EVO-EED-4754-J
🔗 Related Issue
None created yet
🧪 Type of Change
🧪 Testing
📸 Screenshots (if applicable)
✅ Checklist
📝 Additional Notes
Summary by Sourcery
Streamline ChannelStartupService’s message cleaning by removing unnecessary base64 and mediaUrl handling to prevent runtime errors
Bug Fixes:
Enhancements: