Update to handle disabled users in a variety of ways. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just throwing exceptions and causing errors in the tasks.
rfrovarp
pushed a commit
to NDSU-Information-Technology/connector-zoom
that referenced
this pull request
Sep 9, 2025
Was submitted as part of PR ExclamationLabs#35 to main project. Committing here so I have a comprehensive version to build from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just throwing exceptions and causing errors in the tasks.
Fixes #25
We do delayed delete, so Zoom accounts stick around for a while. I believe that disabled Zoom Phone still counts as a license, so we want to remove that license (and free up that phone number) on disabled users. My disable user and disable Zoom phone processes almost always run at different times. Removal of the Zoom Phone feature removes all of the other pieces, so just caring about the feature is sufficient. I also have the issue that other user info can change after they have been disabled. So I added two options for that: ignore or fire the updates. With everything set to the default of false, the behavior of the connector doesn't change.