Add Esc key behavior to Reports search similar to SearchRouter #81072

carlosmiceli · 2026-01-30T23:08:03Z

Explanation of Change

I thought it was inconsistent that the pressing Escape when focused on the Search bar in the Reports page didn't remove focus like the chat switcher search bar, so tweaking that.

Video below is using CMD + K to focus, and then Esc to unfocus:

Screen.Recording.2026-01-30.at.3.09.01.PM.mov

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-30T23:08:38Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001 · 2026-01-30T23:10:23Z

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

+        }
+    }, []);
+
+    useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.ESCAPE, handleEscapeKey, {


this change lgtm, but should we use the search inputs onKeyDown event so that we arent adding a global listener?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0f6dc7cd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-30T23:14:48Z

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

+    const handleEscapeKey = useCallback(() => {
+        if (textInputRef.current?.isFocused()) {
+            textInputRef.current.blur();
+        }
+    }, []);
+
+    useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.ESCAPE, handleEscapeKey, {
+        captureOnInputs: true,
+        shouldBubble: false,


Avoid swallowing Escape when input not focused

Because useKeyboardShortcut defaults to shouldPreventDefault=true and shouldBubble=false (see src/hooks/useKeyboardShortcut.ts), this handler will consume every Escape keypress on the Search page even when textInputRef isn’t focused (the callback no-ops). That prevents the global Escape handler in AuthScreens from running, so pressing Escape won’t dismiss modals/RHP overlays opened from the Search page unless they register their own Escape handler. Consider only activating the shortcut while the input is focused or allowing the event to bubble.

Useful? React with 👍 / 👎.

codecov · 2026-01-30T23:17:29Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/SearchAutocompleteInput.tsx	`81.81% <ø> (ø)`
.../Search/SearchPageHeader/SearchPageHeaderInput.tsx	`36.21% <20.00%> (-0.46%)`	⬇️
... and 55 files with indirect coverage changes

carlosmiceli · 2026-01-31T03:13:47Z

@JS00001 ready again!

add escape key behavior to Search Page bar

c0f6dc7

carlosmiceli self-assigned this Jan 30, 2026

carlosmiceli requested review from a team as code owners January 30, 2026 23:08

melvin-bot bot requested review from trjExpensify and removed request for a team January 30, 2026 23:08

carlosmiceli requested review from JS00001 and removed request for a team and trjExpensify January 30, 2026 23:08

melvin-bot bot requested a review from dangrous January 30, 2026 23:08

JS00001 requested changes Jan 30, 2026

View reviewed changes

carlosmiceli changed the title ~~Add Esc key behavior to Search Page input similar to SearchRouter~~ Add Esc key behavior to Reports search similar to SearchRouter Jan 30, 2026

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

carlosmiceli added 4 commits January 30, 2026 18:17

change method for onKeyPress

929027e

prettier

46b12fe

lint

60e644f

thought I commited this, prettier again

adaed02

carlosmiceli requested a review from JS00001 January 31, 2026 03:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Esc key behavior to Reports search similar to SearchRouter #81072

Add Esc key behavior to Reports search similar to SearchRouter #81072

Uh oh!

carlosmiceli commented Jan 30, 2026 •

edited

Loading

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

JS00001 Jan 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Jan 30, 2026

Uh oh!

codecov bot commented Jan 30, 2026 •

edited by github-actions bot

Loading

Uh oh!

carlosmiceli commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add Esc key behavior to Reports search similar to SearchRouter #81072

Are you sure you want to change the base?

Add Esc key behavior to Reports search similar to SearchRouter #81072

Uh oh!

Conversation

carlosmiceli commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

JS00001 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

carlosmiceli commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carlosmiceli commented Jan 30, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited by github-actions bot

Loading