[NoQA] fix: allow travel invoicing beta testing #81084
Conversation
melvin-bot
bot
requested review from
JmillsExpensify and
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b016fe1c92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const mainContent = (() => { | ||
| // TODO: Remove this conditional when Travel Invoicing feature is fully implemented | ||
| if (isTravelInvoicingEnabled) { | ||
| if (!hasSettlementAccount) { | ||
| return <GetStartedTravel policyID={policyID} />; | ||
| } | ||
| return <WorkspaceTravelInvoicingSection policyID={policyID} />; | ||
| } |
There was a problem hiding this comment.
When a workspace has Travel Invoicing beta enabled but the travel request is still pending (i.e., getTravelStep would return REVIEWING_REQUEST because lastTravelSignupRequestTime is set and the travel-verified beta is off), this unconditional isTravelInvoicingEnabled branch short-circuits the switch and makes the ReviewingRequest screen unreachable. That regresses the legacy flow by hiding the “reviewing request” status for those users and pushes them into the Travel Invoicing setup even though their travel access hasn’t been approved. Consider checking step before this beta gate or explicitly allowing the REVIEWING_REQUEST branch to render when applicable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@blimpich Do you think this is a concern or the previously existing Travel section was no-op anyway ? Or people are actually using the old Travel section in production ? If that's the case we might want to lock this PRs changes to dev / adhoc / staging only - let me know!
@blimpich To confirm if what I detailed in PR explanation of changes / testing steps is kinda what you asked for or I should adjust to what @parasharrajat mentioned 🙌 |
2 participants
Explanation of Change
At @blimpich's request, this PR unlocks access will allow testing the Travel Invoicing (see 📹 below). All you need is:
If you have beta enabled but don't have account, you'll be prompted to add account just like on Expensify card initial flow, if you have both then you'll land directly on the Travel Invoicing page ✅
📝 Notes
📹
Screen.Recording.2026-01-30.at.19.16.37.mov
📷
Fixed Issues
$ #78673
PROPOSAL:
Tests
Preconditions:
Note: If BA is not added, the
Let's gobutton on Travel page will trigger the add bank account flow (RHP) just like the Expensify card initial page does if no bank account is added.Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-01-30.at.19.54.01.mov