Chat- Thread message is not shown in the detail page adding conditional parsing logic to ReportDetailsPage.tsx

[whiletrace]

Explanation of Change

Modify ReportDetailsPage.tsx to match the conditional parsing logic
ADD_COMMENT threads: Don't parse preserves text exactly as
entered)
Group chats: Don't parse (preserves exact text)
Other cases: Parse with htmlToText() as before

Fixed Issues

$ #75979
PROPOSAL: #75979 (comment)

Tests

Testing Steps

Priority 1: Critical Tests

Test 1: Original Issue

Scenario: Thread detail page shows HTML as user typed it

Steps:

1. Open any chat
2. Send message: <div>test</div>
3. Long press message → "Reply in thread"
4. Click thread header → Detail page opens
5. Verify detail page shows <div>test</div> (not "test")

---

Test 2: Header and Detail Page Parity

Scenario: Thread header and detail page show identical text

Steps:

1. Use same thread from Test 1
2. Note thread header text
3. Click thread header → Open detail page
4. Verify header text === detail page text (exact match)

---

Test 3: System Messages

Scenario: System-generated HTML still parses correctly

Steps:

1. Find thread with system-generated message
2. Open detail page
3. Verify system HTML parses correctly (not shown as raw tags)

---

Test 4: Regular (Non-Thread) Chat Detail Pages

Scenario: Backward compatibility for normal chats

Steps:

1. Open any regular chat (not a thread)
2. Click chat header/avatar → Detail page opens
3. Verify detail page works normally
4. Verify chat name displays correctly

---

Test 5: Group Chat Thread

Scenario: Group chat threads handle HTML correctly

Steps:

1. Open a group chat (3+ people)
2. Send message: <b>Bold Test</b>
3. Long press → "Reply in thread"
4. Click thread header → Detail page opens
5. Verify detail page shows <b>Bold Test</b> correctly
6. Verify header matches detail page

---

Priority 2: Important Tests

Test 6: LHN (Left-Hand Navigation) Consistency

Scenario: Thread name in sidebar matches detail page

Steps:

1. Use thread from Test 1 (<div>test</div>)
2. Return to main view
3. Check thread in left-hand navigation list
4. Verify LHN shows same text as header/detail page

---

Test 7: @Mention in Thread Detail

Scenario: Backend HTML (mentions) display correctly

Steps:

1. Send message with @mention: "Hey @[User] check this"
2. Create thread from that message
3. Click thread header → Detail page
4. Verify mention displays as @Username (not raw HTML tags)

---

Test 8: Non-ADD_COMMENT Thread

Scenario: System message threads parse HTML correctly

Steps:

1. Find system-generated message (expense notification, workspace change, etc.)
2. Create thread from it (if possible)
3. Click thread header → Detail page
4. Verify system message HTML parses correctly
5. Verify header matches detail page

---

Test 9: Workspace Report Detail Page

Scenario: Workspace contexts unaffected

Steps:

1. Open a workspace (not thread, not chat)
2. Click workspace name/avatar → Detail page
3. Verify workspace detail page still works
4. Verify workspace name displays correctly

---

Priority 3: Edge Cases

Test 10: Complex Nested HTML

Scenario: Complex HTML edge cases

Steps:

1. Send message: <div><b>nested</b> tags</div>
2. Create thread
3. Open detail page
4. Verify shows exactly as typed

---

Test 11: Empty/Null Thread Name

Scenario: Edge case handling

Steps:

1. Create thread with minimal/empty text
2. Open detail page
3. Verify handles gracefully (no crash, no errors)

---

Test 12: Search Results Consistency

Scenario: Search results match detail page

Steps:

1. Use thread from Test 1
2. Search for "test" or "div"
3. Verify search result matches detail page text

• Verify that no errors appear in the JS console

Offline tests

disconnected network while in production build
Navigate to staging.new.expensify.com
Open a chat
Send a message -

test

Long press and open reply thread
Go to thread header and open header page

QA Steps

"Same as tests"
// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[whiletrace]

when testing IOS standalone I did come across an unrelated console error

[github-actions]

❌ CONSISTENCY-2 (docs)

The condition split across lines 355-356 creates a magic line break that reduces readability. The condition would be more readable if kept on a single line or properly formatted with clear indentation.

Suggested fix:

const shouldParseFullTitle = parentReportAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT && !isGroupChat;

---

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

[github-actions]

❌ PERF-11 (docs)

The code now uses report instead of reportForHeader (which is defined on line 353). This change appears unintentional and could cause bugs, especially for invoice chat threads where getReportForHeader returns the parent invoice report.

Previous code:

getReportNameFromReportNameUtils(reportForHeader, reportAttributes)

Current code:

getReportNameFromReportNameUtils(report, reportAttributes)

Reasoning: The reportForHeader variable was computed via useMemo specifically for this purpose. Using report directly bypasses the logic in getReportForHeader() which handles special cases like invoice chat threads. This inconsistency could lead to incorrect report names being displayed.

Suggested fix:

const reportName = shouldParseFullTitle 
    ? Parser.htmlToText(getReportNameFromReportNameUtils(reportForHeader, reportAttributes)) 
    : getReportNameFromReportNameUtils(reportForHeader, reportAttributes);

---

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac6ad0f4c7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/ReportDetailsPage.tsx	56.31% <100.00%> (+0.27%)	⬆️
... and 56 files with indirect coverage changes