Skip to content

chore: refactor contract releasese#117

Merged
JoE11-y merged 1 commit intomainfrom
stellar-integrations
Apr 14, 2026
Merged

chore: refactor contract releasese#117
JoE11-y merged 1 commit intomainfrom
stellar-integrations

Conversation

@JoE11-y
Copy link
Copy Markdown
Contributor

@JoE11-y JoE11-y commented Apr 14, 2026

Summary by CodeRabbit

  • Chores

    • Simplified GitHub release tag naming convention.
    • Updated docker-local documentation and configuration examples to reflect new artifact naming scheme.
  • Bug Fixes

    • Enhanced EVM readiness detection in the docker-local environment.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 538486e7-f0dd-4833-85af-c4593ea5cfcd

📥 Commits

Reviewing files that changed from the base of the PR and between a613207 and 61ddf9e.

📒 Files selected for processing (7)
  • .github/workflows/contracts-release.yml
  • scripts/docker-local/.env.example
  • scripts/docker-local/Dockerfile.deployer
  • scripts/docker-local/README.md
  • scripts/docker-local/docker-compose.yaml
  • scripts/docker-local/entrypoint.sh
  • scripts/docker-local/up.sh

📝 Walkthrough

Walkthrough

This pull request renames GitHub release artifacts from a contracts-* naming convention to a simpler * format (e.g., contracts-latest becomes latest), updates all related documentation and scripts to reflect the new release naming, and replaces the EVM anvil health check mechanism from a cast command to a raw JSON-RPC eth_blockNumber call via curl.

Changes

Cohort / File(s) Summary
Release Naming Configuration
.github/workflows/contracts-release.yml, scripts/docker-local/up.sh
Updated immutable per-commit release from contracts-${short_sha} to ${short_sha}, and rolling latest release from contracts-latest to latest. Display names now include "Proofbridge-Contracts" prefix. Default bundle tag in up.sh changed accordingly.
Documentation & Configuration
scripts/docker-local/.env.example, scripts/docker-local/README.md, scripts/docker-local/docker-compose.yaml, scripts/docker-local/Dockerfile.deployer
Updated inline comments and documentation to reflect new release naming scheme from contracts-latest to Proofbridge-Contracts latest. Example commands updated from CONTRACTS_BUNDLE_TAG=contracts-<short-sha> to CONTRACTS_BUNDLE_TAG=<short-sha>.
Health Check Mechanism
scripts/docker-local/entrypoint.sh
Replaced EVM anvil readiness probe from cast block-number --rpc-url command to raw JSON-RPC eth_blockNumber POST request via curl, checking for "result":"0x in response.

Suggested reviewers

  • Ugo-X

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Release tags now shine so clean,
From contracts-latest to latest scene,
Health checks curl where cast once stood,
Proofbridge-Contracts names—all good!
Simpler paths through Docker lands,
Organized by fluffy rabbit hands. 🎀

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stellar-integrations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JoE11-y JoE11-y merged commit 9cd9257 into main Apr 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant