Apply wp-ai-client connect timeout to cURL#1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CURLOPT_CONNECTTIMEOUT.Why
PR #1796 added a connect-timeout setting/filter and propagated request options through the model and prompt builder. Local validation then showed WordPress core's
WP_AI_Client_HTTP_Clientmaps only total timeout fromRequestOptionsinto WP HTTP args, so the actual cURL connect timeout still needed to be applied through Data Machine's scopedhttp_api_curlhook.Testing
php tests/wp-ai-client-request-timeout-smoke.php— 25 assertionsphp -l inc/Engine/AI/RequestBuilder.php && php -l tests/wp-ai-client-request-timeout-smoke.phpgit diff --check origin/main...HEADAI assistance