Require explicit memory modes for prompt injection#1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modesas registered/manageable but not prompt-injected.retrieval_policy: neverand filtering non-eager files fromget_for_mode().MODE_ALLopt-ins for Data Machine core memory files that should remain injected, plus regression coverage for external runtime files.Why
AGENTS.mdand similar convention files exist for external runtimes with filesystem/WP-CLI access, not for AI prompt memory. Previously, omitted modes defaulted toall, so external-only files were injected into pipeline AI requests as noise.Testing
php -l inc/Engine/AI/MemoryFileRegistry.phpphp -l inc/bootstrap.phpphp -l tests/Unit/AI/Memory/MemoryPolicyResolverTest.phphomeboy test data-machinecurrently fails one unrelated existing test:DataMachine\\Tests\\Unit\\Abilities\\ImageGenerationPromptRefinementTest::test_refine_prompt_includes_post_context_when_providedexpectsArticle context:but receives an empty string. The memory policy tests passed in the full run.AI assistance