Skip to content

Fix loop queue backup restoration#1811

Merged
chubes4 merged 1 commit intomainfrom
fix/loop-queue-restore-duplicates
May 6, 2026
Merged

Fix loop queue backup restoration#1811
chubes4 merged 1 commit intomainfrom
fix/loop-queue-restore-duplicates

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 6, 2026

Summary

  • Add shared job helper semantics for restoring queued item backups only when drain-mode consumption removed the item.
  • Route manual retry and stuck-job recovery through the same restoration path for prompt and config patch queues.
  • Add focused smoke coverage for loop, drain, and static restoration behavior across both queue slots.

Tests

  • php tests/job-queue-backup-restore-smoke.php
  • php -l inc/Abilities/Job/JobHelpers.php && php -l inc/Abilities/Job/RetryJobAbility.php && php -l inc/Abilities/Job/RecoverStuckJobsAbility.php && php -l tests/job-queue-backup-restore-smoke.php
  • php tests/queue-consumption-consolidation-smoke.php
  • php tests/queue-payload-split-smoke.php
  • ./vendor/bin/phpcs inc/Abilities/Job/JobHelpers.php inc/Abilities/Job/RetryJobAbility.php inc/Abilities/Job/RecoverStuckJobsAbility.php tests/job-queue-backup-restore-smoke.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Fixing loop-mode queue restoration semantics for job retry/recovery and updating tests. Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 6, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since 68213a5

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since 68213a5

Audit

audit — passed

  • test_coverage — 28 finding(s)
  • intra-method-duplication — 8 finding(s)
  • parallel-implementation — 5 finding(s)
  • dead_code — 3 finding(s)
  • dead_guard — 2 finding(s)
  • Directives — 1 finding(s)
  • Retention — 1 finding(s)
  • Total: 48 finding(s)

Deep dive: homeboy audit data-machine --changed-since 68213a5

Tooling versions
  • Homeboy CLI: homeboy 0.157.1+3408dce2
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: ebde078
  • Action: Extra-Chill/homeboy-action@v2

@chubes4 chubes4 merged commit edb444a into main May 6, 2026
3 checks passed
@chubes4 chubes4 deleted the fix/loop-queue-restore-duplicates branch May 6, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant