Skip to content

Split fetch item reject and defer dispositions#1815

Merged
chubes4 merged 1 commit intomainfrom
feat/defer-item-reject-source
May 6, 2026
Merged

Split fetch item reject and defer dispositions#1815
chubes4 merged 1 commit intomainfrom
feat/defer-item-reject-source

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 6, 2026

Summary

  • Replace the overloaded fetch skip tool with explicit reject_source and defer_item dispositions.
  • Keep rejected sources marked processed while deferrals release the active source claim and leave the item retry eligible.
  • Add a focused smoke test covering reject/defer semantics, positive tool descriptions, legacy tool removal, and normal processed marking coverage.

Tests

  • php tests/fetch-item-dispositions-smoke.php
  • php tests/processed-item-claims-smoke.php
  • php -l inc/Core/Steps/Fetch/Tools/FetchItemDispositionTool.php && php -l inc/Core/Steps/Fetch/Handlers/FetchHandler.php && php -l tests/fetch-item-dispositions-smoke.php
  • vendor/bin/phpcs inc/Core/Steps/Fetch/Tools/FetchItemDispositionTool.php inc/Core/Steps/Fetch/Handlers/FetchHandler.php tests/fetch-item-dispositions-smoke.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Implementing explicit reject/defer source dispositions for fetch-item tool handling and adding regression tests. Chris remains responsible for review and merge.

@chubes4 chubes4 merged commit 77589dc into main May 6, 2026
3 checks passed
@chubes4 chubes4 deleted the feat/defer-item-reject-source branch May 6, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant