Skip to content

[Refactor] BaseSimpleTable wraps RenderTable for optional editing and validation #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonnyTran merged 12 commits into from
Dec 7, 2025
Merged

[Refactor] BaseSimpleTable wraps RenderTable for optional editing and validation #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
42e08bf
Initial plan
Copilot Nov 27, 2025
c868d86
Initial plan for BaseSimpleTable refactoring to wrap RenderTable
Copilot Nov 27, 2025
7543c89
Refactor BaseSimpleTable to wrap RenderTable for optional editing and…
Copilot Nov 27, 2025
5dd0947
Fix TypeScript types - import DataFrameSchema from Schema.ts and use …
Copilot Nov 27, 2025
15b1909
refactor: wrap RenderTable inside BaseSimpleTable + unify editing flow
Sparshr04 Dec 3, 2025
a191ef9
refactor: remove unnecessary emits from RenderTable and BaseSimpleTable
JonnyTran Dec 6, 2025
31382e8
Simplify BaseSimpleTable to always use RenderTable, remove tableJSON …
Copilot Dec 6, 2025
e4d5ef4
Merge branch 'develop' into copilot/refactor-basicsimpletable-editing
JonnyTran Dec 6, 2025
bf1f8f0
fix: tableupload only accepting pdf files
JonnyTran Dec 7, 2025
d95ca82
chore: import Tabulator CSS for improved table styling in BaseSimpleT…
JonnyTran Dec 7, 2025
68191d5
Merge branch 'develop' into copilot/refactor-basicsimpletable-editing
JonnyTran Dec 7, 2025
47af289
fix: correct capitalization in import documents title for consistency
JonnyTran Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion extralit-frontend/components/base/base-render-table/RenderTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,11 @@ export default {
this.tableJSON.data.forEach((row) => {
removeColumns.forEach((field) => {
this.$delete(row, field);

});
});
}

}

if (add) {
Expand Down Expand Up @@ -458,7 +460,6 @@ export default {
if (options?.saveData == true) {
this.updateTableJsonData();
}

return isValid;
},
toggleShowRefColumns() {
Expand Down Expand Up @@ -836,6 +837,7 @@ export default {
button.addEventListener('click', this.addEmptyReferenceRows);
div.appendChild(button);
}

return div;
},

Expand Down Expand Up @@ -942,6 +944,7 @@ export default {
this.isLoaded = true;
this.tabulator?.setColumns(this.columnsConfig);
this.validateTable();
this.$emit("table-built");
});

} catch (error) {
Expand Down
Loading
Loading