Skip to content

Move scalar IC out of case.f90#2283

Open
timofeymukha wants to merge 19 commits intoExtremeFLOW:developfrom
timofeymukha:refactor/scalar_ic
Open

Move scalar IC out of case.f90#2283
timofeymukha wants to merge 19 commits intoExtremeFLOW:developfrom
timofeymukha:refactor/scalar_ic

Conversation

@timofeymukha
Copy link
Collaborator

This PR moves the work to set up initial conditions away from the case type and into the scalars and scalar_scheme types. It provides a welcome cleanup, and consolidates scalar-related functionality inside the right types.

I also add an integration test that tests all the initial conditions, both with a "scalar" in the case and a "scalars" with two scalars, one of which is "temperature".

P.S. I think using the temperature field as a special case with flds is cursed. I am actually not sure if things work, if "temperature" doesn't happen to be the first scalar introduced in the case file

@timofeymukha
Copy link
Collaborator Author

This is a rather peculiar set of of failed CI workflows.

@njansson
Copy link
Collaborator

njansson commented Feb 2, 2026

For consistency, shouldn't we do similar things with fluid?

@timofeymukha
Copy link
Collaborator Author

For consistency, shouldn't we do similar things with fluid?

Yes, I will in a new PR once we get this one in. But first gotta fix the issue with field ics here..

@njansson
Copy link
Collaborator

njansson commented Feb 3, 2026

For consistency, shouldn't we do similar things with fluid?

Yes, I will in a new PR once we get this one in. But first gotta fix the issue with field ics here..

Great!

Copy link
Collaborator

@njansson njansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@timofeymukha timofeymukha added the don't merge Don't merge yet! label Feb 3, 2026
@timofeymukha
Copy link
Collaborator Author

I'm putting a don't merge here before we resolve the field IC issue in develop. For some reason, here I do not see if for the single scalar case, which indicates that two minuses became a plus, so to speak :-)). We need to be systematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

don't merge Don't merge yet! refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants