Move scalar IC out of case.f90#2283
Open
timofeymukha wants to merge 19 commits intoExtremeFLOW:developfrom
Open
Move scalar IC out of case.f90#2283timofeymukha wants to merge 19 commits intoExtremeFLOW:developfrom
timofeymukha wants to merge 19 commits intoExtremeFLOW:developfrom
Conversation
Collaborator
Author
|
This is a rather peculiar set of of failed CI workflows. |
Collaborator
|
For consistency, shouldn't we do similar things with |
Collaborator
Author
Yes, I will in a new PR once we get this one in. But first gotta fix the issue with field ics here.. |
Collaborator
Great! |
Collaborator
Author
|
I'm putting a don't merge here before we resolve the field IC issue in develop. For some reason, here I do not see if for the single scalar case, which indicates that two minuses became a plus, so to speak :-)). We need to be systematic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the work to set up initial conditions away from the case type and into the scalars and scalar_scheme types. It provides a welcome cleanup, and consolidates scalar-related functionality inside the right types.
I also add an integration test that tests all the initial conditions, both with a "scalar" in the case and a "scalars" with two scalars, one of which is "temperature".
P.S. I think using the temperature field as a special case with flds is cursed. I am actually not sure if things work, if "temperature" doesn't happen to be the first scalar introduced in the case file