[JOSS REVIEW] Simplify installation#234
Merged
adperezm merged 3 commits intoExtremeFLOW:mainfrom Feb 23, 2026
Merged
Conversation
This was referenced Feb 20, 2026
Collaborator
|
Thank you! Very appreciated. I will check these changes and the issues and get back to you as soon as everything is integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think you could drastically simplify the installation instructions. In particular you should
a) Add all dependencies to your
pyproject.tomlb) Add your library to
pypiso that you can only dopip install pysemtoolsI have added a few examples in this PR to show you how this can be done, but will create separate issues for it.
For the index-url for pytorch you consider using
uv(see https://docs.astral.sh/uv/guides/integration/pytorch/).This is related to the ongoing review at openjournals/joss-reviews#8767