Open
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Upgrade @dhis2/app-runtime to 3.17.0 (adds @dhis2/data-engine peer), render the Aggregate Data Entry app via <Plugin> with typed plugin-specific props, and allow overriding the plugin URL for local development via VITE_DATA_ENTRY_PLUGIN_URL.
Mirror the DataEntry approach: inject a <style> element into the iframe's document with display:none rules instead of querying and mutating the DOM. This removes the setDashboardStyling / waitforElementToLoad polling, the findDOMNode-via-string-ref, and unifies the title format across Dashboard and DataEntry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
🦶 Usability changes to aggregated Data Entry
(To be confirmed by the client)
✋ Changes to dhis.conf
https://docs.dhis2.org/en/full/manage/dhis-core-version-master/system-administration-guide.html
DHIS2 +42 has set restrictive defaults to configuration settings that limit categories and category combos. Make sure to update
dhis.conf, as default values are very low and the app won't work with them. Proposal:Defaults:
Proposal (higher max_options, to accommodate all teams):