Fix: adds real audiodevice type #488
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasMaupin
approved these changes
Jun 23, 2025
Comment on lines
+35
to
+49
| export type TAudioDevice = { | ||
| name: string; | ||
| maxInputChannels: number; | ||
| maxOutputChannels: number; | ||
| defaultSampleRate: number; | ||
| defaultLowInputLatency: number; | ||
| defaultLowOutputLatency: number; | ||
| defaultHighInputLatency: number; | ||
| defaultHighOutputLatency: number; | ||
| isInput: boolean; | ||
| isOutput: boolean; | ||
| hostApiName: string; | ||
| label?: string; | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| export type TAudioDevice = { | |
| name: string; | |
| maxInputChannels: number; | |
| maxOutputChannels: number; | |
| defaultSampleRate: number; | |
| defaultLowInputLatency: number; | |
| defaultLowOutputLatency: number; | |
| defaultHighInputLatency: number; | |
| defaultHighOutputLatency: number; | |
| isInput: boolean; | |
| isOutput: boolean; | |
| hostApiName: string; | |
| label?: string; | |
| }; | |
| export type TAudioDevice = { | |
| name: string; | |
| maxChannels: number; | |
| defaultSampleRate: number; | |
| defaultLowLatency: number; | |
| defaultHighLatency: number; | |
| type: "input" | "output"; | |
| hostApiName: string; | |
| label?: string; | |
| }; | |
malmen237
reviewed
Jun 26, 2025
| isInput: boolean; | ||
| isOutput: boolean; | ||
| hostApiName: string; | ||
| label?: string; |
Contributor
There was a problem hiding this comment.
label?: string;
or
label: string;
malmen237
reviewed
Jun 26, 2025
Comment on lines
103
to
105
| {d.label && d.label.length > 40 | ||
| ? `${d.label.slice(0, 40)}...` | ||
| : d.label} |
Contributor
There was a problem hiding this comment.
{d.label && d.label.length > 40 ? `${d.label.slice(0, 40)}...` : d.label}
This will cause an error on first load if the manager doesn't add label to new audioDevices
malmen237
requested changes
Jun 26, 2025
Contributor
malmen237
left a comment
malmen237
left a comment
There was a problem hiding this comment.
We need to determine if the label is created in the manager or if the UI creates the label, since it's not part of the port-audio original parameters. If it is optional this will lead to some issues, that needs to be fixed.
malmen237
force-pushed
the
feat/ingest-page
branch
from
61818a3 to
70801fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the type of the audio device from the mock format to the real format received