fix: support multiple payload-types #182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated audio payload type handling to support multiple payload types.
Update comments for clarity on payload-type handling.
birme
approved these changes
Jan 13, 2026
Contributor
birme
left a comment
birme
left a comment
There was a problem hiding this comment.
Looks good, thank you for the contribution.
Just for my knowledge, which version of the symphony media bridge were you running when discovered this?
Contributor
|
Just fix the linting issues and I can merge this |
Refactor audio payload type selection logic for clarity. Reformat for linting.
Author
|
The SMB repo I used was https://github.com/finos/SymphonyMediaBridge.git |
FDj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error when trying to join an intercom channel:
Exception thrown when trying to create endpoint: TypeError: Cannot read properties of undefined (reading 'id')
Manager listening on http://127.0.0.1:8000
Media Bridge at http://host.docker.internal:8081 (60s idle timeout)
Created user session: "Meh": 5b5f9cb7-400a-4c75-a42e-1220251ea805
[connection b5ca8365-cb0f-4678-8575-077ceb054b8f] Create, sfuResourceId Meh
TypeError: Cannot read properties of undefined (reading 'id')
at Connection.addIngestMids (/app/src/connection.ts:183:52)
at Connection.createOffer (/app/src/connection.ts:70:10)
at CoreFunctions.createConnection (/app/src/api_productions_core_functions.ts:69:50)
at Object. (/app/src/api_productions.ts:706:46)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
The problem was that payload-type is no longer a single entry, but there's now a payload-types array. To fix this, if we don't find payload-type, use the "opus" entry from payload-types if present, otherwise the first entry in payload-types, then proceed as before.