add a bunch of tests for preblast#69
Open
weshayutin wants to merge 1 commit intoF3Nation-Community:mainfrom
Open
add a bunch of tests for preblast#69weshayutin wants to merge 1 commit intoF3Nation-Community:mainfrom
weshayutin wants to merge 1 commit intoF3Nation-Community:mainfrom
Conversation
* a number of users in denver f3 are complaining preblast is not working. One HIM thought it might be emojo's in the preblast. I promised to check it out. The preblast code seems fine. * Having some tests may help in the future :) Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Author
|
obviously these were generated w/ ai :) |
Contributor
|
Hey thanks for the look! So yes, the preblast thing is a problem with emojis... it's a slack app issue (mostly ios from what I can tell) that I can't fix. So just have your guys avoid using emojis for now. As for the PR, I may look at it, though I'll mention that I'm not really actively developing slackblast, because it's soon to be replaced by the F3 Nation app: https://github.com/F3-Nation/f3-nation-slack-bot/. I'd love help! |
Author
|
@evanpetzoldt I'll start getting setup w/ the app on the new repo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preblast code seems fine.