Fix #63 Update to make "latest" default on deployment template #65
Open
TJbredow wants to merge 1 commit intoF5Networks:masterfrom
Open
Fix #63 Update to make "latest" default on deployment template #65TJbredow wants to merge 1 commit intoF5Networks:masterfrom
TJbredow wants to merge 1 commit intoF5Networks:masterfrom
Conversation
Running CRI-O, the colon appended before the version being added would fail to pull the image. Added logic to account for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Image pull would error on machines running CRI-O due to the colon being added after the image name regardless of whether the version variable was defined in the values.yaml.
Solution: Added logic to only have the colon when version is defined.
Testing: Ran helm chart on cluster running CRI-O and another running Containerd