Skip to content

Fixing problem with inconsistent signal line colours #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eshwen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing problem with inconsistent signal line colours #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fast_plotter/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def __call__(self, col, **kwargs):
width = self.linewidth
style = "-"
else:
color = None
color = color
Copy link
Contributor

@DBAnthony DBAnthony Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do something like color if color else None?

Copy link
Contributor Author

@eshwen eshwen Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can try that. Seems like an easy enough change

Copy link
Contributor Author

@eshwen eshwen Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that doesn't work as intended. If there's no colour tied to a dataset, it's given one from the default colourmap (nipy-spectral, not tab10)

label = col.name
width = 2
style = "--"
Expand Down