Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at autoscaling x and y axes. Hopefully the function can be cleaned up a lot. Currently doesn't work properly for a negative y-axis. For the y-axis, it adds a variable-sized 'buffer' to account for the legend, so that it doesn't overlap with data. Size of buffer is a function of yscale and ymax. X-scale is scaled to remove whitespace in bin edges, so for example MET starts at 200 rather than 0, removing bins with <0.1 entries to calculate the upper xlimit.
Autoscaling for each axis is turned on in config with:
`autoscale: ['x','y']
Doesn't work quite as wanted yet (need better system for determining size of y-axis buffer) so marked as draft.
With default axis scaling (no limits provided in plotter config):
With autoscaling: