Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum error of any bin in
nshould be 1.15, which is the poissonian error for 0 counts. We don't want this error to be plotted for every bin in our standard plots, but it can be turned on in the config with:is_null_poissonian: True.We won't want this for standard plots like below, but is useful for e.g. mountain range plots, or fit-binned plots. Obviously better solution would be explicitly calculating the poisson error and plotting asymmetric errors, but this is better than nothing. I'm taking the quad sum of 1.15 and the 'default' error so that the error is > 1.15 for nonzero yields. Ideally would find a way to ignore the underflow bin.
I'm also not sure whether this minimum value should be applied to monte-carlo, as I am currently, or just data.
With and without this option, and also with autoscaling also turned on, which looks better:
