Test cases for strict identifier system validation #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… StrictIdentifierSystems # Conflicts: # validator/manifest.json
| "severity" : "information", | ||
| "code" : "business-rule", | ||
| "details" : { | ||
| "text" : "Identifier.system is not based on example.org or example.com and is not a preferred URI of any identifier system NamingSystems. Ensure that the Identifier.system value is a properly defined system value" |
Collaborator
There was a problem hiding this comment.
I think this language is a problem. It should be 'chcek' not 'ensure' - it's not wrong to use something for which there's no NamingSystem. Or maybe it should say 'best practice is to declare the system in a NamingSystem resource'
| { | ||
| "name": "identifier-systems", | ||
| "file": "patient-identifiers.xml", | ||
| "description": "Check that identifier systems are valid", |
Collaborator
There was a problem hiding this comment.
it's not valid, it's 'declared'
grahamegrieve
requested changes
Jan 27, 2026
Collaborator
grahamegrieve
left a comment
grahamegrieve
left a comment
There was a problem hiding this comment.
per comments - language is too strong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides tests for checking hapifhir/org.hl7.fhir.core#2202