Skip to content

fix #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhiqiangxu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix #112

zhiqiangxu wants to merge 1 commit into from

Conversation

@zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Jun 13, 2024

The original interface is awkward, there's no need for onlyManagerOrBurner if it can only burn from _msgSender().

@ghostant-1017
Copy link
Contributor

ghostant-1017 commented Jun 17, 2024

When we modify a function's signature, the callers also need to make corresponding changes
https://github.com/FILL-Lab/FILLiquid/blob/cedric/TGE/contracts/Governance.sol#L270

@zhiqiangxu
Copy link
Contributor Author

zhiqiangxu commented Jun 17, 2024

Good spot, I think a non-priviledged burn method will be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhiqiangxu @ghostant-1017