Skip to content

Conversation

@droslbl
Copy link
Contributor

@droslbl droslbl commented Nov 27, 2025

Greetings @wistefan

As for the lastUpdate feature, we all agreed that TMForum should be compliant to the original TMForum specification as you said in the last pull request.

With that said, I was requested to add a few things that are required:

  • LastUpdate is a mandatory field for those entities that should have it, for this reason I added to fieldCleaningSerializer a condition that, for those entities that has the field, no matter what it should always return lastUpdate field along with id and href.

e.g. when querying with ?fields=none it always returns id and href but no lastUpdate. The condition checks if the field exist on the class and imposes it.

  • There are 4 entities: partyRole, billingAccount, financialAccount, settlementAcount that does not include the field despite it being defined so in this PR we are adding those too.

Sources:
Account - https://tmf-open-api-table-documents.s3.eu-west-1.amazonaws.com/OpenApiTable/TMF666_Account/5.0.0/user_guides/TMF666_Account_userguide.pdf
Party Role - https://tmf-open-api-table-documents.s3.eu-west-1.amazonaws.com/OpenApiTable/TMF669_Party_Role/5.0.0/user_guides/TMF669_Party_Role_userguide.pdf

  • Lastly we updated test for service-catalog and customer bill management as well as adding the required tests for the mentioned entities

If anything else is required please do tell me to solve it ASAP.

Best regards

@wistefan
Copy link
Collaborator

Hi @droslbl ,
sorry to say, but you are checking the wrong version of the Api. This is an implementation of the TMForum API v4.0. And in that, the lastUpdate does not exist for the mentioned entities. While I´m open for PRs that do an update to 5.0, we cannot mix both versions.

@droslbl
Copy link
Contributor Author

droslbl commented Nov 27, 2025

Hi @wistefan

Apologizes, I'll check version 4 and ammend the branch accordingly

Best regards

@droslbl
Copy link
Contributor Author

droslbl commented Nov 27, 2025

After checking the API, finally we are removing lastUpdate from the entities, only keeping the logic for the field to appear if its defined in the API
Apologizes for the confusion

@droslbl droslbl force-pushed the feature/clear_lastUpdate branch from 0775c43 to bf8b7f3 Compare November 27, 2025 14:56
@droslbl
Copy link
Contributor Author

droslbl commented Nov 27, 2025

Hi @wistefan

I finished the changes, with this it should be compliant to version 4, again sorry for my confusion earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants