Add support for nested global entries #651

revolter · 2023-02-10T11:40:21Z

Please review each commit separately, as this PR is logically split into multiple "slow" transitions from the current implementation to the new one.

revolter · 2023-02-10T12:36:18Z

In Swift, if you don't use the closure argument, like this:

FLEXManager.shared.registerGlobalEntry(withName: "Name") { _ in
    print("Log")
}

you now get the build error:

Ambiguous use of 'registerGlobalEntry'

and the only workaround that I can think of is changing the call to:

FLEXManager.shared.registerGlobalEntry(withName: "Name") { (_: UITableViewController) in
    print("Log")
}

or

FLEXManager.shared.registerGlobalEntry(withName: "Name") { (_: FLEXUserGlobalEntriesContainer) in
    print("Log")
}

But this means that you have to look into FLEX's files to find this out, if you're new to it.

So, I will rename the new method (from Swift's POV, the first parameter name), to avoid this ambiguity:

FLEXManager.shared.registerNestedGlobalEntry(withName: "Name") { _ in
    print("Log")
}

revolter · 2023-03-10T12:11:10Z

@NSExceptional, do you have time to look over this? 😁

NSExceptional · 2023-03-10T14:47:56Z

Not at the moment no; I was actually in a serious car accident on Tuesday and just got out of the hospital yesterday 🤕

I reviewed a PR yesterday but it was just a small bug fix

NSExceptional · 2023-03-10T14:48:31Z

I'll try to get to this when I can use my hand again

revolter · 2023-03-10T16:11:52Z

OMG, I'm so sorry to hear that 😱 Forget about this PR, get well soon 🤗

revolter · 2023-03-16T15:27:57Z

I also added support for optionally customizing the cell accessory type:

Before	After

NSExceptional · 2024-08-25T08:36:38Z

Hey dawg! I'm finally getting around to clearing out all these PRs and issues that have accumulated over the last year. Sorry for the delay. I appreciate your patience (and frequent contributions).

Still reviewing, but I'm curious, what's the use case for changing the cell accessory type?

This is so we can remove the (now) superfluous methods that only forward the same parameters to the new container object.

revolter · 2024-08-25T16:51:06Z

Hey dawg! I'm finally getting around to clearing out all these PRs and issues that have accumulated over the last year. Sorry for the delay. I appreciate your patience (and frequent contributions).

Hey man! Glad to have you back ❤️

Still reviewing, but I'm curious, what's the use case for changing the cell accessory type?

It's to be able to distinguish nested menus (Level 2 - Nested) from "leaf" menus (Level 2 - Action):

Simulator Screenshot - iPhone 15 (Default) - 2024-08-25 at 19 48 16

I force-pushed a rebase and also fixed the conflicts.

revolter · 2025-11-14T13:00:53Z

@NSExceptional, would you have some time to check this, and hopefully merge it? 🙏🏻

It would reduce the overhead of using and syncing a fork in order to use this functionality.

NSExceptional · 2025-12-04T02:14:41Z

Classes/ExplorerInterface/Tabs/FLEXTabsViewController.m

+                FLEXGlobalsViewController *controller = [FLEXGlobalsViewController new];
+                controller.customEntries = FLEXManager.sharedManager.globalEntriesContainer.entries;
+                controller.showsDefaultEntries = YES;
+


Instead of doing this little dance each time we create one of these, can we just add a convenience init that does this for us so that it becomes [FLEXGlobalsViewController newWithCustomEntries] or something? It can even have that BOOL parameter if you think that's useful

NSExceptional · 2025-12-04T02:15:59Z

Classes/GlobalStateExplorers/Globals/FLEXGlobalsEntry.h


-+ (instancetype)entryWithEntry:(Class<FLEXGlobalsEntry>)entry row:(FLEXGlobalsRow)row;
+ (instancetype)entryWithEntry:(Class<FLEXGlobalsEntry>)entry
+             cellAccessoryType:(UITableViewCellAccessoryType)cellAccessoryType
+                           row:(FLEXGlobalsRow)row;

 + (instancetype)entryWithNameFuture:(FLEXGlobalsEntryNameFuture)nameFuture
+                  cellAccessoryType:(UITableViewCellAccessoryType)cellAccessoryType
               viewControllerFuture:(FLEXGlobalsEntryViewControllerFuture)viewControllerFuture;

 + (instancetype)entryWithNameFuture:(FLEXGlobalsEntryNameFuture)nameFuture
+                  cellAccessoryType:(UITableViewCellAccessoryType)cellAccessoryType
                             action:(FLEXGlobalsEntryRowAction)rowSelectedAction;


In addition to these new ones, can we keep the original signatures around and have them default to the disclosure indicator? Removing them is a breaking change I'd like to avoid

NSExceptional · 2025-12-04T02:17:46Z

Classes/GlobalStateExplorers/Globals/FLEXGlobalsViewController.m

I probably need to just set up a pre-commit linter hook, but in the meantime can we discard all the trailing whitespace changes?

NSExceptional · 2025-12-04T02:20:39Z

Classes/GlobalStateExplorers/Globals/FLEXUserGlobalEntriesContainer.h

A lot of the comments on these methods are repeated for each method. Can we just describe the future blocks and their caveats (i.e. the @note about their lifetimes) in a doc comment on the type itself? It would shorten this file dramatically.

Also, can we rename this to Custom instead of User?

NSExceptional · 2025-12-04T02:22:52Z

Classes/GlobalStateExplorers/Globals/FLEXUserGlobalEntriesContainer.h

+/// Removes all registered global entries.
+- (void)clearGlobalEntries;


Is this method necessary at all? I'm having a hard time imagining a scenario in which you'd want to un-register everything, or anything for that matter

NSExceptional · 2025-12-04T02:25:14Z

Classes/Manager/FLEXManager+Extensibility.h

 /// @note The passed block will be copied and retain for the duration of the application,
 /// you may want to use __weak references.
- (void)registerGlobalEntryWithName:(NSString *)entryName objectFutureBlock:(id (^)(void))objectFutureBlock;
+- (void)registerGlobalEntryWithName:(NSString *)entryName objectFutureBlock:(id (^)(void))objectFutureBlock __attribute((deprecated("Use the same method on the globalEntriesContainer property instead.")));


I see no reason to depreciate the old method, I'm not in a hurry to add more warnings for people to deal with

Suggested change

- (void)registerGlobalEntryWithName:(NSString *)entryName objectFutureBlock:(id (^)(void))objectFutureBlock __attribute((deprecated("Use the same method on the globalEntriesContainer property instead.")));

- (void)registerGlobalEntryWithName:(NSString *)entryName objectFutureBlock:(id (^)(void))objectFutureBlock;

And so on for the rest below

NSExceptional · 2025-12-04T02:28:03Z

Classes/GlobalStateExplorers/Globals/FLEXUserGlobalEntriesContainer.m

Does this really need to be its own type? Any reason it can't be an extension on FLEXManager itself?

revolter force-pushed the add/nested-global-entries branch from 544945a to 5c4a218 Compare August 4, 2023 12:28

NSExceptional added enhancement awaiting response … from the author, to proceed labels Aug 25, 2024

revolter and others added 13 commits August 25, 2024 19:49

Fix typos

63ac9e3

Add demo global entries

23352da

Move main global entries code to a dedicated class

97cb8c8

Remove trailing whitespace

813272b

Simplify a property name

a0ef72c

Make globals view controller's custom entries configurable

d667c1f

Make globals view controller's default entries state configurable

50116df

Make globals view controller's title configurable

7771063

Add support for nested global entries

23f0644

Deprecate the old global entries methods

730d6f9

This is so we can remove the (now) superfluous methods that only forward the same parameters to the new container object.

Avoid ambiguous build error in Swift

e6e9f73

Add support for optionally customizing the cell accessory type

3773272

Fix confusing navigation stack for nested global entries

94b6883

revolter force-pushed the add/nested-global-entries branch from 5c4a218 to 94b6883 Compare August 25, 2024 16:50

NSExceptional reviewed Dec 4, 2025

View reviewed changes

		/// Removes all registered global entries.
		- (void)clearGlobalEntries;

	- (void)registerGlobalEntryWithName:(NSString *)entryName objectFutureBlock:(id (^)(void))objectFutureBlock __attribute((deprecated("Use the same method on the globalEntriesContainer property instead.")));
	- (void)registerGlobalEntryWithName:(NSString *)entryName objectFutureBlock:(id (^)(void))objectFutureBlock;

Uh oh!

Add support for nested global entries #651

Are you sure you want to change the base?

Add support for nested global entries #651

Uh oh!

Conversation

revolter commented Feb 10, 2023

Uh oh!

revolter commented Feb 10, 2023

Uh oh!

revolter commented Mar 10, 2023

Uh oh!

NSExceptional commented Mar 10, 2023

Uh oh!

NSExceptional commented Mar 10, 2023

Uh oh!

revolter commented Mar 10, 2023

Uh oh!

revolter commented Mar 16, 2023

Uh oh!

NSExceptional commented Aug 25, 2024

Uh oh!

revolter commented Aug 25, 2024

Uh oh!

revolter commented Nov 14, 2025

Uh oh!

NSExceptional Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

NSExceptional Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NSExceptional Dec 4, 2025 •

edited

Loading

NSExceptional Dec 4, 2025 •

edited

Loading