Skip to content

CORE-477 fix the resource-viewer #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
safydy-r wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CORE-477 fix the resource-viewer #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions dist/flow-builder.common.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/flow-builder.common.js.map
View file
Open in desktop

Large diffs are not rendered by default.

58 changes: 29 additions & 29 deletions dist/flow-builder.umd.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/flow-builder.umd.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/flow-builder.umd.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/flow-builder.umd.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/components/interaction-designer/ResourceViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="resource-viewer-contents">
<resource-viewer-block
v-for="block in activeFlow?.blocks ?? []"
v-show="visibleBlocks.includes(block.uuid)"
v-show="visibleBlocks === null || visibleBlocks.includes(block.uuid)"
Copy link
Member Author

@safydy-r safydy-r Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm proposing here to always display those block if the visibleBlocks is null, which would allow us to make a test on that edge case scenario.

:id="`block/${block.uuid}`"
:key="block.uuid"
:block="block"
Expand Down