Open
Conversation
Added a hex2dfu built binary for arm64 for Mac. Updated hex2dfu submodule to RusEFI prod branch Force the use of objcopy and objdump from arm-none-eabi toolchain in common_make.sh Use darwin hex2dfu binary in Mac Fixes FOME-Tech#466
nmschulte
reviewed
Jun 29, 2025
| @@ -35,8 +35,12 @@ fi | |||
|
|
|||
| if uname | grep "NT"; then | |||
Contributor
There was a problem hiding this comment.
I wonder if we can tap/factor the platform detection logic in firmware/use_arm_gcc.mk, in the future.
Author
There was a problem hiding this comment.
do you mean that you'd like to make the detection just there and pass it along the build process? I did take inspiration from the logic there, but I didn't find a simple way to pass it along to the common_make script
Contributor
There was a problem hiding this comment.
- I wanted to create awareness about it; glad you'd seen it.
- We'd have to factor something to make them common, but I'm not sure along which lines makes sense (entirely w/in Make, via vars? or via callable
.shscript? or ??) - I don't expect it to be part of this changeset; unnecessary unless there's an obvious solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a hex2dfu built binary for arm64 for Mac.
Updated hex2dfu submodule to RusEFI prod branch
Force the use of objcopy and objdump from arm-none-eabi toolchain in common_make.sh
Use darwin hex2dfu binary in Mac in common_make.sh
Fixes #466