Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FRB repository with new data from Muller et al. 2025 Xshooter observations, including two new FRB host galaxies (20231230D and 20240117B) and various data format improvements.
- Added new FRB entries and host galaxy data for FRB20231230D and FRB20240117B from Muller et al. 2025
- Fixed redshift format inconsistencies by converting string values to numeric types in JSON files
- Updated error messages and documentation to correct author/year references
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frb/surveys/nedlvs.py | Added print_query parameter for debugging NEDLVS catalog queries |
| frb/rm.py | Updated author year references in error messages from 2020 to 2022 |
| frb/io.py | Removed deprecated Python 2 compatibility imports |
| frb/galaxies/frbgalaxy.py | Added redshift handling logic in from_dict method |
| frb/data/Galaxies/public_hosts.csv | Added two new FRB entries and corrected FRB20171020 name format |
| frb/data/Galaxies/Literature/shannon2024_photom.csv | Updated coordinates for FRB20240201A |
| frb/data/Galaxies/Literature/muller2025_photom.csv | Added new photometry data file for Muller 2025 observations |
| frb/data/Galaxies/Literature/all_refs.csv | Added reference entry for Muller 2025 paper |
| Multiple JSON files | Added comprehensive host galaxy data for new FRBs and fixed redshift format issues |
| frb/data/FRBs/FRBs_base.csv | Added base FRB data for two new events |
| frb/builds/*.py | Added proper error handling for optional dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SunilSimha
approved these changes
Sep 13, 2025
Collaborator
SunilSimha
left a comment
SunilSimha
left a comment
There was a problem hiding this comment.
Requesting a minor change. Otherwise, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ui.adsabs.harvard.edu/abs/2025arXiv250620774M/abstract