Open
Conversation
Just typos fixing and some additions/changes
…frbhosts_template
profxj
requested changes
Jan 9, 2026
Contributor
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
Nice! Just a few requests from me in the code, but let me also
ask for tests. And, a bit of docs for readthedocs. Or point
to an existing Google doc
Thanks!
| # -------------------------------------------------------------------- | ||
| # JSON helpers | ||
| # -------------------------------------------------------------------- | ||
| def load_json(path: Path): |
Contributor
There was a problem hiding this comment.
these already exist in the Repo. in io.py
| return None | ||
|
|
||
|
|
||
| def get_scalar_from_source(source_data, key): |
Contributor
There was a problem hiding this comment.
here and throuhgout the module, please define the input argument.s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.