A bunch of things! Most notably, explicit use of survey beamwidth#74
Merged
cwjames1983 merged 8 commits intomainfrom Nov 19, 2025
Merged
A bunch of things! Most notably, explicit use of survey beamwidth#74cwjames1983 merged 8 commits intomainfrom
cwjames1983 merged 8 commits intomainfrom
Conversation
added 5 commits
October 24, 2025 16:11
…g, added new function to plotting, and various minor tweaks to MeerKAT and SKA plots
…so added files to load known states, and tried removing some resource_filename calls
…that would have failed, simplified get_log_likelihood, cleaned some aspects of calc_likelihoods functions
profxj
approved these changes
Nov 3, 2025
Contributor
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
thx for removing all the pkg_resources
| @@ -0,0 +1,378 @@ | |||
| """ | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has been a bit of a catch-all for a few miscellaneous updates being implemented simultaneously.
The most significant is the addition of explicit use of beam value B in calc likelihoods 1D and 2D, and the ability of survey.py to read in beam values internally. It's hoped that using this from even a single survey will allow explicit values of FRB energy to be used in constraining the luminosity function.
At the same time, I have revamped the use of "dolist" within calc_likelihoods_[1/2]D to report components of the likelihood. This is great for debug purposes - see script zdm/scripts/likelihood_components.py for examples of its use.
There are also maybe a few additions to scripts within the MeerTRAP and SKA "papers" folders, adding minor functionality.
And I did a few other bits of cleanup - deleted two legacy routines from iteration.py, got rid of some more resource_filename calls, and maybe fiddled here and there with other things.