Closed
Conversation
Member
Author
|
sorry abt earlier failed builds, its when I discovered the .yml issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the build process and minor code corrections. The most significant update is the addition of Gradle caching to the GitHub Actions workflow, which will speed up CI builds. Other changes include a fix to the systemd service file for correct Java invocation and minor code cleanups in the main Java source.
Build process improvements:
.github/workflows/build.ymlto cache dependencies and wrapper files, improving build times. [1] [2]Deployment configuration:
ExecStartcommand inbatteryTracking.serviceto use the-jarflag for running the Java application, ensuring the service starts correctly.Code cleanup and bug fixes:
BatteryTracking.javato use!=instead of!() ==for clarity and correctness.BatteryTracking.javafor better code readability. [1] [2]