-
Notifications
You must be signed in to change notification settings - Fork 3
Actually call resetToAbsolute() #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -133,4 +133,8 @@ public double getWheelRadiusCharacterizationPosition() { | |||||
| public double getFFCharacterizationVelocity() { | ||||||
| return inputs.driveVelocityRadPerSec; | ||||||
| } | ||||||
| // Gets moduleio instance | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
In general, It would be better to use 3 slashes in comments above functions because that makes the comment interpreted as a javadoc, meaning it will appear when you hover over the function |
||||||
| public ModuleIO getModuleIO(){ | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not good practice to allow direct access to the IO interface from elsewhere. Instead, could you make a function that calls the function in the io interface? |
||||||
| return io; | ||||||
| } | ||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,7 @@ public static Drive buildDefaultDrive(CommandXboxController driveController) { | |
| drive.setPose( | ||
| new Pose2d(drive.getPose().getTranslation(), new Rotation2d())), | ||
| drive) | ||
| .andThen(drive.resetModulesToAbsolute()) // Resets modules when button pressed | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| .ignoringDisable(true)); | ||
| return drive; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function needs to ignore disabling