-
Notifications
You must be signed in to change notification settings - Fork 7
submitting Dynamic Jams to repository. #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Goober5000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through this. It's a nice feature and I'm sure Scroll, for one, will be able to use it. I'll have to play around with it.
I spotted a few spelling mistakes but don't let those crowd out the overall pretty positive review.
One important thing though is managing the dependencies. You include several files here from both SendMessageAltSEXPs and PlasmaCore. These files should be removed, and instead Dynamic Jams should specify that these scripts are dependencies. This is similar to how AxBase is listed as a dependency for a lot of things; it's better to maintain one copy of AxBase than several.
| @@ -0,0 +1,69 @@ | |||
| --------------------------------------------------------------- | |||
| -------- functions for OOP -------- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a SendMessageAltSEXPs file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, iirc it's required for the demo so I felt it appropriate to include it in the demo. Otherwise anyone attempting to test the demo would need to figure out and add the dependencies used by the mission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise anyone attempting to test the demo would need to figure out and add the dependencies used by the mission
You can assume that anyone using this repository would know how to do that. The entire point of specifying a dependency is to avoid duplicating files in every place that uses them.
Look at PromptBox for example. It depends on AxBase and it will not function without the files in AxBase. Yet the PromptBox demo does not come bundled with the AxBase files.
| @@ -0,0 +1,13 @@ | |||
| #Conditional Hooks | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a PlasmaCore file
Co-authored-by: Goober5000 <Goober5000@users.noreply.github.com>
Co-authored-by: Goober5000 <Goober5000@users.noreply.github.com>
Co-authored-by: Goober5000 <Goober5000@users.noreply.github.com>
Co-authored-by: Goober5000 <Goober5000@users.noreply.github.com>
Co-authored-by: Goober5000 <Goober5000@users.noreply.github.com>
Co-authored-by: Goober5000 <Goober5000@users.noreply.github.com>
Music management system for configurable, mission designer controlled dynamic music. Lua version and demo missions included.