Styled area refactor: Get bounds of paragraph on screen#1314
Open
Symeon94 wants to merge 4 commits intoFXMisc:masterfrom
Open
Styled area refactor: Get bounds of paragraph on screen#1314Symeon94 wants to merge 4 commits intoFXMisc:masterfrom
Symeon94 wants to merge 4 commits intoFXMisc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing and then refactoring some part of the
GenericStyledAreaclass.This was done in three steps:
This is a small step in a bigger move to refactor the code.
For this one I took the liberty to refactor in this PR. The last commits shows the refactor.