create lazy supplier for cures to fix early holder access crashes #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the
MobEffectInstanceMixinwhen populating the list of cures, you are accessing thevalueof the passed effect holder too soon for some use cases.Specifically the following, where a mod creates an effect and also an item with this effect in it's food properties.
The deffered holder of the effect is passed to the
MobEffectInstanceconstructor, but du to porting lib is accessed there directly to create the list of cures.This PR changes this behaviour by moving the cure population to a lazy supplier, therefore only loading once it's accessed the first time and the underlying effect holder has actually been registered.
Mentioned example: