Added Addon::Writer + A few other changes#48
Open
RaphaelIT7 wants to merge 2 commits intoFacepunch:masterfrom
Open
Added Addon::Writer + A few other changes#48RaphaelIT7 wants to merge 2 commits intoFacepunch:masterfrom
RaphaelIT7 wants to merge 2 commits intoFacepunch:masterfrom
Conversation
[+] Added -lowmemory option to write everything directly to the .gma file Reduces the needed memory to only the size of the biggest file in the entire addon. [+] Added -lowmemory and -nocrc to the help list. [#] Reallocating the file buffer only once instead of every time. [#] if necessary, write the .gma in chunks if the buffer gets too full. NOTE: If this happens we cannot create a CRC of the .gma because at this point it would probably fail to load or cause a crash.
[#] Optimized CRC to use the file buffer instead of reading the file again [#] Highly optimized file whitelist [#] Optimized RemoveIgnoredFiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[+] Added
-lowmemoryoption to write everything directly to the .gma fileReduces the needed memory to only the size of the biggest file in the entire addon.
[+] Added
-lowmemoryand-nocrcto the help list.[#] Reallocating the file buffer only once instead of every time.
[#] if necessary, write the .gma in chunks if the buffer gets too full.
NOTE: If this happens we cannot create a CRC of the .gma because at this point it would probably fail to load or cause a crash.